Header style hangs the web page

- 7 years, 4 months ago tyt2y7
  Participant
  
  Expired
  The Codeless header has a bug that hangs the webpage on a specific header style.
  You can reproduce the issue on https://codeless.co/june/default/?product=printed-melange-t-shirt&cl_on&cl_header_change=main13 just hover on the shop icon and the web page now hangs entirely.
  
  It is trapped in this infinite loop.
  
  Analysis
  
  This mainNode is never a parent of item. No doubt it stucks in infinite loop right?
  
  Resolution
  We can simply replace the loop condition to:
  
  while ( ! $(item).hasClass('tool') && ! $(item).hasClass('extra_tools_wrapper') ) {
  
  However now the dropdowns don’t always close. The problem is in the close() function.
  
  mainNode = this.config.$headerTools;
  
  We have to patch this line too.
  
  This topic was modified 7 years, 4 months ago by tyt2y7.
  
  This topic was modified 7 years, 4 months ago by tyt2y7.
  
  This topic was modified 7 years, 4 months ago by Mirela.
- 7 years, 4 months ago Mirela
  Participant
  
  Hello,
  
  This is the responsive header style! You will see it in almost 99% of all available websites. When the screen size is smaller than the menu width, the mobile layout takes over. Where the menu is replaced with the mobile menu icon (three bars menu). It will unfold the menu items when tapped over (mobile) or clicked on (computer).
  
  This is not an issue. You you want to change this, it’s ok. But we recommend you use custom css (in Additional CSS menu) or a child theme. So you won’t lose the changes in case of future theme updates.
  Let us know.
  
  Best regards!
- 7 years, 4 months ago Volya
  Participant
  
  Expired
  
  have the same problem!
  thank you Tyt2y7
  Mihaila, it is the real issue.
  I hope you will fix it urgently
  The last version of the theme has a lot of bugs and this is very serious.
- 7 years, 4 months ago kamilpatyk
  Participant
  
  Expired
  My issue also fixed by this tip, thanks @Tyt2y7 :)
  
  This reply was modified 7 years, 4 months ago by kamilpatyk.
- 7 years, 4 months ago Volya
  Participant
  
  Expired
  @tyt2y7 @kamilpatyk
  
  Can you please say what to fix in the close() function?
  I replaced this line
  while ( ! $(item).hasClass('tool') && ! $(item).hasClass('extra_tools_wrapper') ) {
  and cannot undestand what else should I change
  
  thank you
  
  This reply was modified 7 years, 4 months ago by Volya.
- 7 years, 4 months ago kamilpatyk
  Participant
  
  Expired
  
  @Volya
  
  line number 3003
  mainNode = this.config.$headerTools[0];
  to
  mainNode = this.config.$headerTools;
- 7 years, 4 months ago Volya
  Participant
  
  Expired
  
  thank you @kamilpatyk
  I did it, but there is still an issue.
  When I hover on wishlist in the header my tab crushed and I even cannot start to debug :-(
  https://new.world4kidz.co.uk/
- 7 years, 4 months ago tyt2y7
  Participant
  
  Expired
  @Mihaila
  
  This is not a false alarm. I have professional engineers helping to me fix theme bugs everyday. And this is a common thing to happen. Just to be sure you put in the necessary effort to investigate, fix and patch the bugs. So that we can benefit others later to come. Otherwise you are harming yourself. I will forgive some bugs given that June is a really young theme.
  
  Please get back to the engineers, evaluate this patch, and update it ASAP. You can reproduce the issue on https://codeless.co/june/default/?product=printed-melange-t-shirt&cl_on&cl_header_change=main13 just hover on the shop icon.
  
  @kamilpatyk
  
  Thank you. Sorry for not make myself absolutely clear. There are only two line of code to change, and exactly as mentioned.
  
  @Volya
  
  You site seems perfectly normal to me now.
  
  This reply was modified 7 years, 4 months ago by tyt2y7.
- 7 years, 4 months ago Mirela
  Participant
  
  Hello,
  
  I am sorry for not understanding your point. I have referred this to theme developer and we will try to release an update as soon as we can.
  
  Thank you all for the cooperation!
  
  Best regards!
- 7 years, 4 months ago Volya
  Participant
  
  Expired
  
  @tyt2y7
  Thank you, yes now it works fine. I suppose that because the LiteSpeed web server causes a problem with cache I need more time to implement changes.
  
  I agree that the June theme is young but perspective, so we need to be patient and
  I will forgive some bugs but expect a quick fix for serious bugs.
- 7 years, 4 months ago tyt2y7
  Participant
  
  Expired
  
  Cool that everyone is happy now, cheers :)
- 7 years, 4 months ago Ludjon
  Keymaster
  
  Thanks to all of you for mentioning this issue :)
  Just Updated, next release will be ok.
  
  Thanks again!