-
-
The Codeless header has a bug that hangs the webpage on a specific header style.
You can reproduce the issue on https://codeless.co/june/default/?product=printed-melange-t-shirt&cl_on&cl_header_change=main13 just hover on the shop icon and the web page now hangs entirely.
It is trapped in this infinite loop.
Analysis
This mainNode is never a parent of item. No doubt it stucks in infinite loop right?
Resolution
We can simply replace the loop condition to:while ( ! $(item).hasClass('tool') && ! $(item).hasClass('extra_tools_wrapper') ) {However now the dropdowns don’t always close. The problem is in the close() function.
mainNode = this.config.$headerTools;We have to patch this line too.
-
My issue also fixed by this tip, thanks @Tyt2y7 :)
-
Can you please say what to fix in the close() function?
I replaced this line
while ( ! $(item).hasClass('tool') && ! $(item).hasClass('extra_tools_wrapper') ) {
and cannot undestand what else should I changethank you
-
This is not a false alarm. I have professional engineers helping to me fix theme bugs everyday. And this is a common thing to happen. Just to be sure you put in the necessary effort to investigate, fix and patch the bugs. So that we can benefit others later to come. Otherwise you are harming yourself. I will forgive some bugs given that June is a really young theme.
Please get back to the engineers, evaluate this patch, and update it ASAP. You can reproduce the issue on https://codeless.co/june/default/?product=printed-melange-t-shirt&cl_on&cl_header_change=main13 just hover on the shop icon.
Thank you. Sorry for not make myself absolutely clear. There are only two line of code to change, and exactly as mentioned.
You site seems perfectly normal to me now.
-
You must be logged in to reply to this topic.